Do not show unused widgets at startup#439
Conversation
When starting without wallets the labelWalletEncryptionIcon and labelWalletHDStatusIcon widgets are not required.
|
Only watched it in action on macOS, but it works. Thank you! |
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK 489060d
Confirmed the related bug (#428) and tested that this fixes it. The issue here is that we aren't hiding the unused icons. The PR fixes the issue by hiding them. When they are needed again (when you create a wallet), they are properly shown. Tested on macOS 12.
| Bug on master | PR | Create Wallet, Icons will still Appear |
|---|---|---|
 |
 |
 |
489060d qt: Do not show unused widgets at startup (Hennadii Stepanov) Pull request description: On master (8d83f9c), when starting without wallets the `labelWalletEncryptionIcon` and `labelWalletHDStatusIcon` widgets are not used but still visible as empty space:  If one opens any wallet then closes it, the widget layout becomes densed:  This PR makes widget layout densed at startup. Fixes #428. ACKs for top commit: jarolrod: ACK 489060d promag: Code review ACK 489060d. Tree-SHA512: bda7195225ecd203bb3269ebe7fc264aaf7f57b922deb83a04127584a5d6123950741fb431161523e84630927c2f617e85c085bbbe75ad8559da7b2947de1bdd
|
Port it back to 22 please? And maybe 0.21 as well? (If backport policy includes this kind of unimportant stuff) |
|
@katesalazar Do you have a specific rationale for requesting this PR to be backported? (It doesn't help that you call it unimportant yourself 😄 ) |
|
@laanwj I could risk suggesting there is no "UI issues" really, |
5 participants
On master (8d83f9c), when starting without wallets the
labelWalletEncryptionIconandlabelWalletHDStatusIconwidgets are not used but still visible as empty space:If one opens any wallet then closes it, the widget layout becomes densed:
This PR makes widget layout densed at startup.
Fixes #428.