refactor: Fix deprecation warnings when building against Qt 5.15 by hebasto · Pull Request #46 · bitcoin-core/gui

hebasto · 2020-08-09T17:33:40Z

To help preparing for the transition to Qt 6, numerous classes and member functions that will be removed from Qt 6.0 have been marked as deprecated in the Qt 5.15 release.

Fixes #36

promag · 2020-08-09T23:28:32Z

Concept ACK.

fanquake · 2020-08-18T04:19:51Z

Concept ACK

hebasto · 2020-08-26T17:40:44Z

Rebased 354b2bd -> 705c1f0 (pr46.01 -> pr46.02) due to the conflict with #35.

Sjors · 2020-08-28T12:35:18Z

As mentioned in #36 I don't see any deprecation warnings on macOS with homebrew QT 5.15, but at least this change doesn't introduce new issues for me.

hebasto · 2020-09-25T10:19:03Z

@vasild
As you mention these warnings in bitcoin/bitcoin#19716 (comment), mind looking into this PR?

promag

Tested ACK 705c1f0 on macos with Apple clang version 11.0.3 (clang-1103.0.32.62) and brew qt 5.15.1.

jonasschnelli · 2020-10-23T09:43:52Z

utACK 705c1f0
Added 0.22 milestone.

maflcko

Concept aCK

maflcko · 2020-11-19T18:03:43Z

src/qt/guiutil.cpp

+#endif
+}
+
+QImage GetImage(const QLabel* label)


nit: Could pass by reference?

Suggested change

QImage GetImage(const QLabel* label)

QImage GetImage(const QLabel& label)

maflcko · 2020-11-19T18:10:38Z

btw, I am getting a ton of warnings like this one:

  CXX      qt/libbitcoinqt_a-bantablemodel.o
In file included from qt/bantablemodel.cpp:5:
In file included from ./qt/bantablemodel.h:12:
In file included from /usr/include/qt5/QtCore/QAbstractTableModel:1:
/usr/include/qt5/QtCore/qabstractitemmodel.h:170:5: warning: 'metaObject' overrides a member function but is not marked 'override' [-Wsuggest-override]
    Q_OBJECT
    ^
/usr/include/qt5/QtCore/qobjectdefs.h:175:32: note: expanded from macro 'Q_OBJECT'
    virtual const QMetaObject *metaObject() const; \
                               ^
/usr/include/qt5/QtCore/qobject.h:129:5: note: overridden virtual function is here
    Q_OBJECT
    ^
/usr/include/qt5/QtCore/qobjectdefs.h:175:32: note: expanded from macro 'Q_OBJECT'
    virtual const QMetaObject *metaObject() const; \
                               ^

hebasto · 2020-11-19T19:21:51Z

Compiling on macOS 11.0.1 Big Sur (20B29) + Qt 5.15.1 gives the following warnings now:

a load of -W#pragma-messages from boost 1.74.0

/usr/local/include/boost/function_output_iterator.hpp:14:1: warning: This header is deprecated. Use <boost/iterator/function_output_iterator.hpp> instead. [-W#pragma-messages]
BOOST_HEADER_DEPRECATED("<boost/iterator/function_output_iterator.hpp>")

three -Wdeprecated-declarations about deprecated NSUserNotification (see RFC: Migration from NSUserNotificationCenter to UNUserNotificationCenter on macOS #112 and macOS: Post user notifications using QSystemTrayIcon #114)

warning: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]

and

qt/guiutil.cpp:70:37: warning: 'SystemLocaleShortDate' is deprecated: Use QLocale [-Wdeprecated-declarations]
    return date.date().toString(Qt::SystemLocaleShortDate) + QString(" ") + date.toString("hh:mm");
                                    ^
/usr/local/Cellar/qt/5.15.1/lib/QtCore.framework/Headers/qnamespace.h:1280:31: note: 'SystemLocaleShortDate' has been explicitly marked deprecated here
        SystemLocaleShortDate Q_DECL_ENUMERATOR_DEPRECATED_X("Use QLocale"),
                              ^
/usr/local/Cellar/qt/5.15.1/lib/QtCore.framework/Headers/qcompilerdetection.h:1161:45: note: expanded from macro 'Q_DECL_ENUMERATOR_DEPRECATED_X'
#  define Q_DECL_ENUMERATOR_DEPRECATED_X(x) Q_DECL_DEPRECATED_X(x)
                                            ^
/usr/local/Cellar/qt/5.15.1/lib/QtCore.framework/Headers/qcompilerdetection.h:675:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'
#    define Q_DECL_DEPRECATED_X(text) attribute ((__deprecated__(text)))
                                                      ^
1 warning generated.

Not seening -Wsuggest-override warnings at all 🤷‍♂️

maflcko · 2020-11-19T19:56:33Z

Oh the override warnings happen with clang on linux. E.g fedora or debian:

https://cirrus-ci.com/task/6217749342978048?command=make#L10798

…Date 86b1ab6 refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date (Hennadii Stepanov) Pull request description: As all deprecated warning in Qt 5.15.0 were eliminated in #46, Qt 5.15.1 introduced another one that is fixed in this PR. Required for bitcoin/bitcoin#20182. Details in Qt docs: - https://doc.qt.io/qt-5/qdatetime.html#toString-1 - https://doc.qt.io/qt-5/qdate.html#toString-1 ACKs for top commit: jarolrod: Tested ACK 86b1ab6 on MacOS 10.15.7 and Arch Linux both with Qt 5.15.1 jonasschnelli: Tested ACK 86b1ab6 Tree-SHA512: 1dbba8ee70c895bf58317172a9901cdbe5503b1d6258f51caaae88d88d332d9fbd4697c995192d31e3618ddfd532c5f5881289b3af1184422e5a9263a1224115

bitcoin-core/gui#46 + some adjustments for Raven qt, refactor: Fix 'QDateTime is Deprecated' warnings. qt, refactor: Fix 'QFlags is deprecated' warnings qt, refactor: Fix 'split is deprecated' warnings qt, refactor: Fix 'buttonClicked is deprecated' warnings

* qt: Fix deprecation warnings when building against Qt 5.15 bitcoin-core/gui#46 + some adjustments for Raven qt, refactor: Fix 'QDateTime is Deprecated' warnings. qt, refactor: Fix 'QFlags is deprecated' warnings qt, refactor: Fix 'split is deprecated' warnings qt, refactor: Fix 'buttonClicked is deprecated' warnings * qt, refactor: Use enum type as switch arguments backport from bitcoin qt, refactor: Use enum type as switch argument in TransactionTableModel qt, refactor: Use enum type as switch argument in PeerTableModel qt, refactor: Use enum type as switch argument in BanTableModel qt, refactor: Use enum type as switch argument in AddressTableModel bitcoin#1d5d832d5c045cbbe3a0f4aa8fc29e52ecadc182 bitcoin#52f122c11f5ac40bc2f7e31cb4da0a79c842f08e bitcoin#a35223f1cdaf6918501faccac1ff94ebfd38c6f6 bitcoin#ab8a747d1ced9f20ca32f9898418be70670da71a * qt, refactor: utilitydialog shutdown window qflag * qt, refactor: BanTableModel replace 0 with Qt::NoItemFlags * qt, refactor: ravenamountfield, StepEnabled * qt, refactor: OptionsModel replace qstring.split() * qt, refactor: Fix 'pixmap is deprecated' warnings backport from bitcoin with adjustments for Raven bitcoin#fa5749c805878304c107bcae0ae5ffa401dc7c4d * qt, refactor: PaymentServer qbytearray deprecation warnings remove check for qt < 5.0, we no longer support 4.x.

a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331e Import fixes for sanitizer reported issues d5fb86940e refactor: use c++11 range based for loop in checkObject ff9c379304 refactor: Use nullptr (c++11) instead of NULL 08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d487292 ci: travis -> cirrus c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c65 build: Move source entries out to sources.mk 6c7d94b33c build: cleanup wonky gen usage a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23 f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD 1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix 92bdd11f0b univalue_write: remove unneeded sstream.h include ffb621c130 Merge pull request #56 from drodil/remove_sstream_header f33acf9fe8 Merge commit '7890db9~' into HEAD 66e0adec4d Remove unnecessary sstream header from univalue.h 88967f6586 Version 1.0.4 1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool 72392fb227 [tests] test pushKV for boolean values c23132bcf4 Pushing boolean value to univalue correctly 81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS b17634ef24 Update URLs to MIT license. 88ab64f6b5 Merge pull request #46 from jasonbcox/master 35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit 420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test git-subtree-dir: src/univalue git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3

fanquake mentioned this pull request Aug 19, 2020

build: Qt 5.15.x bitcoin/bitcoin#19716

Closed

bedri mentioned this pull request Aug 19, 2020

QT compilation warnings for develop branch codes with QT version 5.15.0 RavenProject/Ravencoin#791

Closed

DrahtBot added the Needs rebase label Aug 26, 2020

maflcko added the Refactoring label Aug 26, 2020

hebasto added 5 commits August 26, 2020 20:17

qt, refactor: Fix 'QDateTime is deprecated' warnings

b02264c

qt, refactor: Fix 'pixmap is deprecated' warnings

fa5749c

qt, refactor: Fix 'QFlags is deprecated' warnings

8e12d69

qt, refactor: Fix 'split is deprecated' warnings

c2f4e5e

qt, refactor: Fix 'buttonClicked is deprecated' warnings

705c1f0

hebasto force-pushed the 200809-depr branch from 354b2bd to 705c1f0 Compare August 26, 2020 17:37

DrahtBot removed the Needs rebase label Aug 26, 2020

promag reviewed Sep 25, 2020

View reviewed changes

jonasschnelli added this to the 0.22.0 milestone Oct 23, 2020

maflcko reviewed Nov 19, 2020

View reviewed changes

maflcko merged commit 0a267f4 into bitcoin-core:master Nov 19, 2020

hebasto deleted the 200809-depr branch November 19, 2020 19:43

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 19, 2020

Merge bitcoin-core/gui#46: refactor: Fix deprecation warnings when bu…

4c94c5b

This was referenced Nov 25, 2020

qt: Call setParent() in the parent's context bitcoin/bitcoin#18948

Merged

refactor: Replace deprecated Qt::SystemLocale{Short,Long}Date #137

Merged

apoelstra added a commit to apoelstra/elements that referenced this pull request Dec 3, 2020

Merge 0a267f4 into merged_master (Bitcoin PR bitcoin-core/gui#46)

20c7518

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Mar 23, 2021

Merge 0a267f4 into merged_master (Bitcoin PR bitcoin-core/gui#46)

d2e4f52

furszy mentioned this pull request Apr 6, 2021

[GUI] fix 'split is deprecated' warnings PIVX-Project/PIVX#2264

Merged

bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Fix deprecation warnings when building against Qt 5.15#46

refactor: Fix deprecation warnings when building against Qt 5.15#46
maflcko merged 5 commits intobitcoin-core:masterfrom
hebasto:200809-depr

hebasto commented Aug 9, 2020

Uh oh!

promag commented Aug 9, 2020

Uh oh!

fanquake commented Aug 18, 2020

Uh oh!

hebasto commented Aug 26, 2020

Uh oh!

Sjors commented Aug 28, 2020

Uh oh!

hebasto commented Sep 25, 2020

Uh oh!

promag left a comment

Uh oh!

jonasschnelli commented Oct 23, 2020

Uh oh!

maflcko left a comment

Uh oh!

maflcko Nov 19, 2020

Uh oh!

maflcko commented Nov 19, 2020

Uh oh!

hebasto commented Nov 19, 2020 •

edited

Loading

Uh oh!

maflcko commented Nov 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	QImage GetImage(const QLabel* label)
	QImage GetImage(const QLabel& label)

Conversation

hebasto commented Aug 9, 2020

Uh oh!

promag commented Aug 9, 2020

Uh oh!

fanquake commented Aug 18, 2020

Uh oh!

hebasto commented Aug 26, 2020

Uh oh!

Sjors commented Aug 28, 2020

Uh oh!

hebasto commented Sep 25, 2020

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

jonasschnelli commented Oct 23, 2020

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 19, 2020

Uh oh!

hebasto commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Nov 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hebasto commented Nov 19, 2020 •

edited

Loading