refactor: Declare WalletModel member functions with const#590
Merged
hebasto merged 1 commit intobitcoin-core:masterfrom May 9, 2022
Merged
refactor: Declare WalletModel member functions with const#590hebasto merged 1 commit intobitcoin-core:masterfrom
WalletModel member functions with const#590hebasto merged 1 commit intobitcoin-core:masterfrom
Conversation
promag
reviewed
May 9, 2022
kristapsk
approved these changes
May 9, 2022
w0xlt
approved these changes
May 9, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 9, 2022
…nctions with `const` f70ee34 qt, refactor: Declare `WalletModel` member functions with `const` (Hennadii Stepanov) Pull request description: After bitcoin#12830 the `WalletModel` class has two member functions: https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L81 and https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L154 This PR drops the former one as redundant, and declares `WalletModel` member functions with the `const` qualifier where appropriate. ACKs for top commit: promag: Code review ACK f70ee34. kristapsk: cr ACK f70ee34 w0xlt: Code Review ACK bitcoin-core/gui@f70ee34 Tree-SHA512: 43e6661822c667229ea860fb94c2e3154c33773dbd9fca1f6f76cc31c5875a1a0e8caa65ddfc20dec2a43e29e7b2469b3b6fa148fe7ec000ded518b4958b2b38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After bitcoin/bitcoin#12830 the
WalletModelclass has two member functions:gui/src/qt/walletmodel.h
Line 81 in be7a5f2
gui/src/qt/walletmodel.h
Line 154 in be7a5f2
This PR drops the former one as redundant, and declares
WalletModelmember functions with theconstqualifier where appropriate.