Replace QRegExp with QRegularExpression#620
Merged
laanwj merged 3 commits intobitcoin-core:masterfrom Jun 22, 2022
Merged
Conversation
Member
|
Thank you for picking it up! What is your opinion about #606 (comment)? |
hebasto
changed the title
QRegExp with QRegularExpressionQRegExp with QRegularExpression
Contributor
Author
That looks good to me. I'll take a look at it. |
Member
|
w0xlt
force-pushed
the
regexp-obsolete
branch
2 times, most recently
from
39f50ea to
c0c8b33
Compare
Contributor
Author
|
Force-pushed c0c8b33 addressing #606 (comment). |
hebasto
reviewed
Jun 21, 2022
Member
There was a problem hiding this comment.
Approach ACK c0c8b33.
Suggesting to split the first commit into separated ones:
- factoring out the
extractFirstSuffixFromFilter()function (I'd prefer to useUpperCamelCasename convention for this new standalone function) - replacement
QRegExpwithQRegularExpression
Also please apply clang-format-diff.py for each your commit.
hebasto
reviewed
Jun 21, 2022
Extract the 'Extract first suffix from filter pattern...' functionality into a testable utility function
Co-authored-by: Pavol Rusnak <[email protected]> Co-authored-by: Jarol Rodriguez <[email protected]>
Contributor
Author
hebasto
approved these changes
Jun 21, 2022
Member
|
Code review and lightly tested ACK 67364eb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #606 (labeled "Up for grabs") and applying #606 (review) and #606 (comment).
Replaces occurrences of
QRegExpusage withQRegularExpressionas part of the roadmap for Qt6 integration.Fixes #578