Fix Transaction Relay tooltip text in Peers details window#681
Merged
maflcko merged 1 commit intobitcoin-core:masterfrom Nov 17, 2022
Merged
Fix Transaction Relay tooltip text in Peers details window#681maflcko merged 1 commit intobitcoin-core:masterfrom
maflcko merged 1 commit intobitcoin-core:masterfrom
Conversation
as a value of N/A could occur due to a lock or a disconnection race but not during connection setup.
jarolrod
approved these changes
Nov 17, 2022
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK 7a53033
The extra note here is redundant anyway at a UI level; it's not as if you're going to have a script that is dependent on the value the GUI is showing for this when setting up a peer.
One note: it's always nice to add a translation comment to strings as we are updating them. For strings in the .ui files, you can add an extracomment property to the string tag like so:
<string extracomment="nice translator comment">| master | pr |
|---|---|
 |
 |
Member
Author
|
Thanks, @jarolrod! I'll try to keep your translation comment suggestion in mind. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 18, 2022
…rs details window 7a53033 Fix Transaction Relay tooltip text in Peers details window (Jon Atack) Pull request description: as a value of N/A could occur due to a lock or a disconnection race but not during connection setup -- see bitcoin#26457 (review). Credit to Martin Zumsande for finding this. ACKs for top commit: jarolrod: ACK 7a53033 Tree-SHA512: 031779567e927f05f6fae02394a8c97ba5c45ba9fffd7f1e2c006e152df5f724d92a06f18a4c2540436476eca6b40a3a5cbc4421666cd576439b823668acfcfb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a value of N/A could occur due to a lock or a disconnection race but not during connection setup -- see bitcoin/bitcoin#26457 (review). Credit to Martin Zumsande for finding this.