Skip to content

make '-min' minimize wallet loading dialog#749

Merged
hebasto merged 1 commit intobitcoin-core:masterfrom
furszy:2023_gui_start_minimized
Aug 31, 2023
Merged

make '-min' minimize wallet loading dialog#749
hebasto merged 1 commit intobitcoin-core:masterfrom
furszy:2023_gui_start_minimized

Conversation

@furszy
Copy link
Member

@furszy furszy commented Aug 13, 2023

Simple fix for #748.

When '-min' is enabled, no loading dialog should
be presented on screen during startup.

@furszy
gui: make '-min' minimize wallet loading dialog
32db154 
When '-min' is enabled, no loading dialog should
be presented on screen during startup.
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 13, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@furszy furszy changed the title gui: make '-min' minimize wallet loading dialog make '-min' minimize wallet loading dialog Aug 13, 2023
@furszy furszy mentioned this pull request Aug 14, 2023
Closed
pablomartin4btc
pablomartin4btc reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change. Created several wallets in order to see the "Loading wallet..." dialog for a while.
Without your change in master when I run bitcoin-qt -min the dialog is not shown and the app opens as usual.
With your change when I run bitcoin-qt -min, the app gets minimized entirely, is that intentional?

@furszy
Copy link
Member Author

furszy commented Aug 23, 2023

I've tested this change. Created several wallets in order to see the "Loading wallet..." dialog for a while.
Without your change in master when I run bitcoin-qt -min the dialog is not shown and the app opens as usual.
With your change when I run bitcoin-qt -min, the app gets minimized entirely, is that intentional?

Yes. Thats the -min flag purpose: start the app minimized.

hebasto
hebasto approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 32db154, tested on Debian 11 + XFCE.

The bug did not reveal itself on my Ubuntu + GNOME.

@hebasto hebasto merged commit 9561e49 into bitcoin-core:master Aug 31, 2023
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Sep 8, 2023
@hebasto
Merge bitcoin-core/gui#749: make '-min' minimize wallet loading dialog
a2ec5ec
@jonatack
Copy link
Member

jonatack commented Oct 30, 2023

FWIW, a user on #bitcoin IRC mentioned today that this patch wasn't backported to v25.x.

@furszy furszy deleted the 2023_gui_start_minimized branch October 30, 2023 22:15
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@pablomartin4btc pablomartin4btc pablomartin4btc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@furszy @DrahtBot @jonatack @hebasto @pablomartin4btc