Remove legacy wallet creation#764
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
@furszy Thank you! Concept ACK. |
hebasto
changed the title
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
from
9702028 to
6b83663
Compare
|
It would be nice to have screenshots "before" and "after" in the PR description. |
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
2 times, most recently
from
3336abb to
038616b
Compare
furszy
force-pushed
the
2023_gui_remove_legacy_wallet_creation
branch
from
038616b to
b442580
Compare
|
Updated per Sjors's feedback. Thanks. |
| <item> | ||
| <widget class="QLabel" name="label_subdescription"> | ||
| <property name="text"> | ||
| <string>Please provide a name and, if desired, enable any advanced options</string> | ||
| </property> | ||
| </widget> | ||
| </item> |
There was a problem hiding this comment.
nit: is this not implicit? Perhaps we can set it as the tool-tip of the "Create" button? Also I think extracomment attribute for the <string> tag would be needed for the translation.
| <item> | |
| <widget class="QLabel" name="label_subdescription"> | |
| <property name="text"> | |
| <string>Please provide a name and, if desired, enable any advanced options</string> | |
| </property> | |
| </widget> | |
| </item> |
|
ACK b442580 |
|
re-ACK b442580 |
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
post-merge, error message displayed as expected when sqlite is not available (forced with ./configure --without-sqlite)
6 participants
Fixes #763
Preventing users from creating a legacy wallet prior to its deprecation in the upcoming releases.
Note:
This is still available using the
createwalletRPC command.Future Note:
Would be nice to re-write this modal as a wizard. And improve the design.
Pre-Changes Screenshot
Post-Changes Screenshot