Choose monospaced font in C++ code rather in *.ui file#87
Choose monospaced font in C++ code rather in *.ui file#87hebasto wants to merge 1 commit intobitcoin-core:masterfrom
*.ui file#87Conversation
|
@jonasschnelli Should this be considered a bugfix? |
|
Unsure about this. |
How is it so? I think both |
I'd say *.ui is view, *.cpp is controller (the non-automatic generated ones). |
Right. But Qt programming usually assumes "the view and the controller objects are combined" (https://doc.qt.io/qt-5/model-view-programming.html). |
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
Looks good to me, one change requested
src/qt/overviewpage.cpp
Outdated
|
|
||
| QFont f = GUIUtil::fixedPitchFont(); | ||
| f.setWeight(QFont::Bold); | ||
| f.setPointSize(10); |
There was a problem hiding this comment.
Let's not override this for no reason?
There was a problem hiding this comment.
The only reason is to make things explicitly rather than implicitly. Does setPointSize call has any downsides?
There was a problem hiding this comment.
Yes, the downside is that it is explicit and overrides the user's preference (which may not be 10pt).
There was a problem hiding this comment.
Thanks! Updated.
Now I'm able to change the font size with the qt5ct utility on Linux Mint 20 :)
This change makes macOS choose the correct monospaced font.
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
Tested ACK on macOS 10.15.7
Master
PR
|
Master: This PR: I think the correct monospace font should be bigger and eventually bold. |
|
Adding |
|
It would be great to add a font size selector - similar to the console interface.
|
|
Closed in favor of #207 which should be less controversial. |
5 participants
This change makes macOS choose the correct monospaced font.
fanquake noted (bitcoin/bitcoin#16432 (comment)):
... because it is not monospaced.
This is an alternative to #79 as that PR has a Concept NACK from luke-jr.
I'm personally still lean to embedding font as it makes the GUI more stable.