This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Merged
Conversation
Contributor
|
What is the motivation for this? Key derivation is VERY slow in JS. |
Contributor
|
Regarding the speed of derivation, FWIW: https://github.com/cryptocoinjs/hdkey implements derivivaiton using secp256k1 C bindings which is much faster, and bcoin has also started to do something similar at https://github.com/bcoin-org/bcoin/tree/master/lib/hd though is still using cache. |
Contributor
|
Right. That would be great but we also need key derivation in pure JS for
the browser (for copay for example)
…On Dec 8, 2016 10:44, "Braydon Fuller" ***@***.***> wrote:
Regarding the speed of derivation, FWIW: https://github.com/
cryptocoinjs/hdkey implements derivivaiton using secp256k1 C bindings
which is much faster, and bcoin has also started to do something similar at
https://github.com/bcoin-org/bcoin/tree/master/lib/hd though is still
using cache.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGCHEDDKB-wl_KuW_PWiPxLqKLPaTdnks5rGAnYgaJpZM4LHBpJ>
.
|
Contributor
Contributor
Author
|
@matiu How often are we actually re-deriving a key that we previously derived? It seems like that would be a very rare situation. We don't reuse addresses in Copay, so it seems like we would normally just derive a key once and never need it again. |
Contributor
|
@gabegattis based on conversations, both in this thread and external, is this code still ready to merge? |
Contributor
|
ACK |
1 similar comment
Contributor
|
ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#96