[decoration] Backward compatibility (Phase 1)#5262
Merged
bjhargrave merged 1 commit intobndtools:masterfrom May 24, 2022
Merged
[decoration] Backward compatibility (Phase 1)#5262bjhargrave merged 1 commit intobndtools:masterfrom
bjhargrave merged 1 commit intobndtools:masterfrom
Conversation
The decoration changes to always include literals was not backward compatible since it added literals for the `-runbundles`. After some discussion we decided to add `++` for decorations that always add literals and a single `+` for the 6.2 behavior of not adding literals. Since we use decorations requiring adding literals in our own build, this changes adds support for `++` decoration while `+` decoration still adds literals. After this build is complete, we will following with changing our build to use `++` where necessary and also change the `+` behavior back to not adding literals. Signed-off-by: Peter Kriens <[email protected]> Signed-off-by: BJ Hargrave <[email protected]>
bjhargrave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoration changes to always include literals was not backward
compatible since it added literals for the
-runbundles.After some discussion we decided to add
++for decorationsthat always add literals and a single
+for the 6.2 behaviorof not adding literals.
Since we use decorations requiring adding literals in our own build,
this changes adds support for
++decoration while+decorationstill adds literals.
After this build is complete, we will following with changing our
build to use
++where necessary and also change the+behaviorback to not adding literals.