Merged
Conversation
…to 'this'. Issue # 219
…_fix Fixed file_descriptor move assignment operator returns a reference to this.
Master update
Fix missing headers
explicit cast to int to silence this: `error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'int' in initializer list [-Wc++11-narrowing]`
Update executor.hpp
Flamefire
reviewed
May 23, 2022
| cmake_minimum_required(VERSION 3.5...3.16) | ||
|
|
||
| project(boost_process VERSION "${BOOST_SUPERPROJECT_VERSION}" LANGUAGES CXX) | ||
| find_package(Boost REQUIRED iostreams program_options filesystem system thread) |
Contributor
There was a problem hiding this comment.
This breaks the superproject build on which you basically rely by using BOOST_SUPERPROJECT_VERSION
That in turn also breaks dependent libraries
Member
There was a problem hiding this comment.
Confirmed. The Boost CMake build is broken now, as a result of this change. Please fix.
kou
reviewed
Aug 17, 2022
| while (*p != nullptr) | ||
| { | ||
| if (std::equal(st1.begin(), st1.end(), *p)) | ||
| const int len = std::char_traits<Char>::length(*p); |
There was a problem hiding this comment.
Can we use iterator::difference_type here something like const auto len = static_cast<iterator::difference_type>(std::char_traits<Char>::length(*p))?
This causes an warning with Visual C++:
C:\Miniconda37-x64\envs\arrow\Library\include\boost/process/environment.hpp(266): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
C:\Miniconda37-x64\envs\arrow\Library\include\boost/process/environment.hpp(266): warning C4267: 'initializing': conversion from 'size_t' to 'const int', possible loss of data
| while (*p != nullptr) | ||
| { | ||
| if (std::equal(st1.begin(), st1.end(), *p)) | ||
| const int len = std::char_traits<Char>::length(*p); |
| while (*p != nullptr) | ||
| { | ||
| if (std::equal(st1.begin(), st1.end(), *p)) | ||
| const int len = std::char_traits<Char>::length(*p); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.