Have GoReleaser sign and notarize macOS builds#6703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changing
The changes here along with Actions Secrets I've added for the repo will make it such that our macOS
superrelease binaries going forward will be signed and notarized.Why
In looking toward submitting a Cask for
superto the core Homebrew set, the very first thing they caution under reasons for rejection is:Even beyond Homebrew, I've since learned that not having the
superbinary signed/notarized creates potential problems for regular users that may download our releases from GitHub via browser.Details
On my Intel Mac for instance, if I download the most recent SuperDB release v0.2.0 via Chrome, unpack, and run
./super, I get a pop-up like this:The same happens if I install via
brew install --cask brimdata/tap/superper our docs. Experienced users know they can get around this by clicking through an exception in Settings > Privacy & Security. But as we seek to make SuperDB accessible to wider audiences, this is definitely a bad look.In addition to adding them as Repository Secrets here in the repo, I've also saved the values of the secrets in our AWS Secrets Manager under
super_repo_build_secrets.Testing
I've tested out the signing and notarizing in a personal fork repo and have made scratch releases v0.3.0 (which represents a baseline repro of the problem) and v0.6.0 (which is signed and notarized and shows the fix). To verify, in addition to the presence/absence of the pop-up I showed above, with the scratch
v0.3.0artifact we see:And with the scratch
v0.6.0artifact: