fix precision in cast from float16 and float32 to string#6722
Merged
Conversation
Casting some float16 and float32 values to string produces an imprecise result. Fix by providing the correct bitSize parameter to strconv.AppendFloat and FormatFloat as well as discarding extra precision for float16 values in vam.
mccanne
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting some float16 and float32 values to string produces an imprecise result. Fix by providing the correct bitSize parameter to strconv.AppendFloat and FormatFloat as well as discarding extra precision for float16 values in vam.