Tests for problems introduced in [email protected] and fixed in [email protected]#1139
Merged
ljharb merged 1 commit intobrowserify:masterfrom Feb 8, 2019
Merged
Conversation
dominykas
changed the title
dominykas
changed the title
dominykas
force-pushed
the
resolve-exposed-folders
branch
from
975a3a2 to
7a16a7d
Compare
dominykas
changed the title
Contributor
Author
|
After rebasing tests now pass - I assume the tests are still worth merging into the suite? |
Contributor
Author
|
I suppose this is not going in. |
Member
|
It’d be great if this went in. |
Member
|
@dominykas i know this is old, but if you could rebase it, I’d love to see it go in. It will help ensure that resolve doesn’t break behavior in browserify. |
Contributor
Author
|
OK, I'll see what I can do. |
…rmally do, i.e. with/without extension and directories should fall back to index, and index from a directory should be accepted with/without extension too
dominykas
force-pushed
the
resolve-exposed-folders
branch
from
f6d6728 to
f13b713
Compare
Contributor
Author
|
I've no recollection of details of what happened there, but let's see if rebasing makes the tests pass :) |
ljharb
approved these changes
Feb 8, 2019
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
More tests, tests that pass, I'm not seeing a downside
This was referenced May 29, 2021
This was referenced Jun 6, 2021
Merged
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a module is exposed, it should still resolve the way it would normally do, i.e. with/without extension and directories should fall back to index, and index from a directory should be accepted with/without extension too.In this PR there are the tests that will fail - I am not able to run them reliably for some reason, so with[email protected]they simply hang, however they will pass if younpm install [email protected]I'm not sure how to make them pass - that, I believe, belongs in theresolvemodule - I'll create a relevant issue there, mostly because I've no idea how things are wired up.The following tests are added, where
xis a file andyis a folder with anindex.jsinside:b.require('./x', {expose: 'xyz'});b.require('./y', {expose: 'xyz'});b.require('./y/index', {expose: 'xyz'});b.require('./y/index.js', {expose: 'xyz'});