Add http2 to builtins#1913
Add http2 to builtins#1913goto-bus-stop merged 1 commit intobrowserify:masterfrom steve-taylor:master
Conversation
|
You're welcome. Thanks for the quick merge and release! |
|
It might be worth using resolve’s listing of core modules to default all of them to empty (and override with shims as needed) - then this would have Just Worked. |
|
that sounds like a good idea—we've had a few browserify releases lately that were mostly about adding new empty shims. |
|
(Pull in |
|
The set of core modules isn’t the same for all Node versions. We might not necessarily build and run on the same version of Node. Maybe we need an extra option to specify the target runtime, e.g. |
|
@steve-taylor that’s a reasonable addition to resolve if it’s needed; but i do think that building and running on the same version is typical. |
Node.js 10.10.0 added the
http2module. This change adds just enough support for--no-builtins(and therefore--node) to recognisehttp2as a Node.js built-in module and not attempt to bundle it.