Add curl to image to help with Istio liveness checks#147
Merged
jphines merged 1 commit intobuzzfeed:masterfrom Jan 23, 2019
Merged
Add curl to image to help with Istio liveness checks#147jphines merged 1 commit intobuzzfeed:masterfrom
jphines merged 1 commit intobuzzfeed:masterfrom
Conversation
jphines
approved these changes
Jan 23, 2019
Contributor
jphines
left a comment
There was a problem hiding this comment.
Seems reasonable to include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When SSO is deployed with Istio mutual TLS enabled, the normal liveness checks will not work i.e. these:
Further reading here: https://istio.io/help/faq/security/#k8s-health-checks
Solution
The above link suggests using a liveness command, e.g. by installing
curland using that instead.curlis not currently available in the built image, so this PR adds it.It would then be possible to use SSO in a cluster with Istio mutual TLS enabled, i.e. the checks can then be changed to