Merged
Conversation
dd2981f to
0284a7d
Compare
Contributor
|
Yeah, I've found |
|
Thank you for this contribution @sylr! This is definitely an approach that we want to move towards, however one thing that we'd like to discuss separately is whether or not to check in the vendor'ed dependencies. For the time being to get this merged can you check out the dependencies in this PR? |
Author
|
@shrayolacrayon I personally prefer to have the libs vendor'ed for two reason:
|
Contributor
|
@sylr if you can rebase this branch -- we'd love to get it in. |
Signed-off-by: Sylvain Rabot <[email protected]>
Author
|
@jphines done. |
jphines
approved these changes
Feb 19, 2019
Contributor
|
@sylr thanks for the contribution! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpm is totally obsolete so let's move to Go 1.11 and use go mod which is future standard for managing Go dependencies.