providers: group caching mechanism for okta provider#184
Merged
Jusshersmith merged 2 commits intomasterfrom May 10, 2019
Merged
providers: group caching mechanism for okta provider#184Jusshersmith merged 2 commits intomasterfrom
Jusshersmith merged 2 commits intomasterfrom
Conversation
Jusshersmith
force-pushed
the
jusshersmith-okta-sso-group-caching
branch
from
a25247f to
154e82b
Compare
Jusshersmith
changed the title
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
reviewed
May 1, 2019
jphines
previously approved these changes
May 7, 2019
Contributor
jphines
left a comment
jphines
left a comment
There was a problem hiding this comment.
LGTM. Please squash and we can get this!
creation of an on-demand group cache package, and a new 'groupcache' provider wrapper with tests for both.
Jusshersmith
force-pushed
the
jusshersmith-okta-sso-group-caching
branch
from
193dee9 to
02669c1
Compare
jphines
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caching mechanism for groups returned by the Okta provider
groupspackage: internal/pkg/groups/localcache.go for local caching of groups.ValidateGroupMembershipfunction.statsdClientto the provider interface (and adds/modifies the relevant provider function where necessary)