ci: remove minimum coverage setting#214
Merged
Jusshersmith merged 2 commits intomasterfrom Jun 25, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 61.23% 61.21% -0.02%
==========================================
Files 50 50
Lines 4073 4071 -2
==========================================
- Hits 2494 2492 -2
Misses 1393 1393
Partials 186 186
|
Contributor
Author
|
Would we prefer to set a threshold perhaps? (allow the PR to drop by x% (5%?), but still pass) |
Contributor
|
@Jusshersmith the threshold SGTM, maybe 2-3%? |
Jusshersmith
force-pushed
the
jusshermsith-modify-codecov-settings
branch
from
5ea2354 to
da6ba79
Compare
jphines
previously approved these changes
Jun 24, 2019
remove requirement for overall target
Jusshersmith
force-pushed
the
jusshermsith-modify-codecov-settings
branch
from
43a95d4 to
2dae354
Compare
Contributor
Author
|
🙏 @jphines, please review/re-approve when you have the chance. Updated comments slightly to give some information around validating config. |
jphines
approved these changes
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the recent introduction of codecov, builds are failing to pass checks if their coverage falls below that of master.
Solution
Although we want to increase coverage, I'm not sure if we want to set those hard limitations immediately?
If I understand correctly these changes should remove the 'target', so we'll still get the PR comment but it won't fail due to coverage levels.
This also adds the codecov badge to our readme.