Merged
Conversation
Contributor
Author
|
I’m not entirely sure why |
jphines
previously approved these changes
Jun 25, 2019
Contributor
|
Let's get this merged once we understand why the |
Contributor
Author
|
Why |
084c3f1 to
b17f1d6
Compare
jphines
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is currently no automation around tagging SSO docker images with the
latesttag.Solution
This PR proposes moving our CircleCI config to use the ‘workflows’ method introduced in CircleCI
2.0, allowing us to better separate and orchestrate individual jobs.Separates circleci jobs into logical ‘workflows’:
Makefile tasks:
imagepush-latesttask (pushes with thelatesttag)imagepushtoimagepush-committo help separations for circlecilatesttag to the image in thereleasepushtask.Notes
Relevant issues: #193