docs: outline env vars and fix provider setup documentation#240
Merged
Jusshersmith merged 1 commit intomasterfrom Sep 4, 2019
Merged
docs: outline env vars and fix provider setup documentation#240Jusshersmith merged 1 commit intomasterfrom
Jusshersmith merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 62.22% 62.22%
=======================================
Files 50 50
Lines 4072 4072
=======================================
Hits 2534 2534
Misses 1350 1350
Partials 188 188 |
Jusshersmith
force-pushed
the
jusshersmith-config-options
branch
from
bafee34 to
11602c4
Compare
benjsto
reviewed
Aug 23, 2019
benjsto
previously approved these changes
Aug 23, 2019
Contributor
benjsto
left a comment
benjsto
left a comment
There was a problem hiding this comment.
This is a great improvement.
Jusshersmith
force-pushed
the
jusshersmith-config-options
branch
from
ab9340e to
6f7682d
Compare
jphines
reviewed
Aug 27, 2019
Contributor
|
Other than stray syntax, LGTM. |
Jusshersmith
force-pushed
the
jusshersmith-config-options
branch
3 times, most recently
from
2138001 to
bbdf8c5
Compare
Jusshersmith
force-pushed
the
jusshersmith-config-options
branch
from
bbdf8c5 to
78401c1
Compare
benjsto
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Right now it's not abundantly clear what environment variables can be set, and in some cases, their types or defaults as well.
Solution
Adds a list of environment variables that will be read by sso_auth, their types and defaults.
Also added is an extra var in the google provider docs