sso_auth: add default for groupcache settings#246
Merged
Jusshersmith merged 1 commit intomasterfrom Aug 27, 2019
Merged
Conversation
Contributor
|
|
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If
c.refreshTTLis not greater than 0 then a panic is caused upon the execution ofsso/internal/pkg/groups/fillcache.go
Line 118 in 9c169b3
At the moment, there's no default for this so it must be explicitly set to avoid a panic.
Solution
Set a sane default for
refreshTTL(this default was removed during the overhaul of configuration options).