sso_*: fix 500 error caused by expired Okta refresh token#254
Merged
Jusshersmith merged 1 commit intomasterfrom Oct 7, 2019
Merged
sso_*: fix 500 error caused by expired Okta refresh token#254Jusshersmith merged 1 commit intomasterfrom
Jusshersmith merged 1 commit intomasterfrom
Conversation
catch on proxy side use http error string instead of int a bit more lenient error string check
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=========================================
- Coverage 62.37% 62.1% -0.27%
=========================================
Files 50 50
Lines 4093 4101 +8
=========================================
- Hits 2553 2547 -6
- Misses 1355 1366 +11
- Partials 185 188 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We're not catching the right error within the
oktaRequestfunction, causing expired refresh tokens to be categorised under an 'unknown' error type. This results in an unclear and awkward UX in cases where the refresh token has expired.Solution
Fix the error string we're searching for, and improve the general UX around this error case a little bit to provide users with a sensible error and an option to sign back in.
Notes
The TTL of a refresh token in Okta is easily and commonly customised, whereas the TTL of a refresh token within Google is set at 6 months by default. This has meant we've ran into this error a little bit more frequently with the Okta provider which is why we're fleshing out the UX a bit. (This error is generally unseen when the Google provider is being used)