Merged
Conversation
diff created by running scripts/test
Contributor
|
Should we also add |
Contributor
Author
|
Yeah, I think that sounds like a sensible idea @mccutchen! |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 62.21% 62.21%
=======================================
Files 54 54
Lines 4200 4200
=======================================
Hits 2613 2613
Misses 1399 1399
Partials 188 188 |
mccutchen
previously approved these changes
Dec 6, 2019
Contributor
mccutchen
left a comment
mccutchen
left a comment
There was a problem hiding this comment.
LGTM aside from one small nit, thanks @Jusshersmith!
Contributor
Author
|
Think I'm going to need a fresh review on this @mccutchen! (thanks!) |
mccutchen
approved these changes
Dec 9, 2019
Contributor
mccutchen
left a comment
mccutchen
left a comment
There was a problem hiding this comment.
LGTM, thanks @Jusshersmith!
This was referenced Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Updates to certain go modules are required. This is starting to cause errors with new builds: https://circleci.com/gh/buzzfeed/sso/2185?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Solution
Running https://github.com/buzzfeed/sso/blob/master/scripts/test locally edited
go.modandgo.sumfiles as required.