sso_auth: make provider_*_okta_server optional#292
Merged
Jusshersmith merged 2 commits intobuzzfeed:masterfrom May 1, 2020
kjetijor:okta-serverid-optional
Merged
sso_auth: make provider_*_okta_server optional#292Jusshersmith merged 2 commits intobuzzfeed:masterfrom kjetijor:okta-serverid-optional
provider_*_okta_server optional#292Jusshersmith merged 2 commits intobuzzfeed:masterfrom
kjetijor:okta-serverid-optional
Conversation
added 2 commits
April 29, 2020 17:18
The quickstart seems to indicate that this is optional
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 61.87% 61.94% +0.06%
==========================================
Files 57 57
Lines 4640 4638 -2
==========================================
+ Hits 2871 2873 +2
+ Misses 1556 1553 -3
+ Partials 213 212 -1
Continue to review full report at Codecov.
|
Jusshersmith
approved these changes
May 1, 2020
Contributor
Jusshersmith
left a comment
Jusshersmith
left a comment
There was a problem hiding this comment.
Hi @kjetijor,
Thank you contributing and fixing this!
Jusshersmith
changed the title
provider_*_okta_server optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quickstart (and testing in practice) seems to indicate that PROVIDER_*_OKTA_SERVER should be optional, if you wish to use the default okta authorization server.
Solution
Make it optional!
Notes