sso_*: use ProxyFromEnvironment in http Transport#307
Merged
Jusshersmith merged 1 commit intomainfrom Jun 16, 2021
Merged
Conversation
jphines
previously approved these changes
Jun 2, 2021
Jusshersmith
force-pushed
the
jusshersmith-auth-ProxyFromEnvironment
branch
from
63e450a to
71d9c08
Compare
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 62.73% 62.73%
=======================================
Files 58 58
Lines 4286 4286
=======================================
Hits 2689 2689
Misses 1382 1382
Partials 215 215 Continue to review full report at Codecov.
|
Jusshersmith
force-pushed
the
jusshersmith-auth-ProxyFromEnvironment
branch
from
71d9c08 to
26d56b0
Compare
benjsto
approved these changes
Jun 15, 2021
Jusshersmith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As described in #305, some HTTP clients used in
sso_authandsso_proxydon't allow for use ofHTTP_PROXYenvironment variables -- meaning traffic can't be passed through a proxy if desired.Solution
Make use of the http.ProxyFromEnvironment method, which allows for usage of these environment variables.
We already make use of this in one HTTP client within
sso_proxyhere:sso/internal/proxy/reverse_proxy.go
Line 53 in 03e1259