Static assets now built into the binary#63
Conversation
internal/auth/authenticator.go
Outdated
| fsHandler, err := loadFSHandler() | ||
| if err != nil { | ||
| logger.Fatal(err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Actually, I meant to check whether .Fatal calls os.Exit or not before committing. Looks like it does, so this line isn't needed.
There was a problem hiding this comment.
That said this is one of those "this should never happen" errors.
|
I opted to check |
|
So it seems like the Edit |
|
OK, closer, but maybe an issue with wrong version of Go? |
|
Failures that only happen in CI/CD are always fun. |
|
I'm going to squash the fighting-with-CircleCI commits. |
sporkmonger
force-pushed
the
static-assets
branch
from
a356d18 to
3895a11
Compare
|
Ready for review. |
|
Thanks for opening @sporkmonger! We'll be working on reviewing and getting this merged as soon as we can. |
|
One more request - we should be able to also get rid of copying over the static directory in the Dockerfile when building the docker image. Since we are still working on figuring out a good way to build and push docker images for forked community contributions, I've pushed a copy of your pr branch on buzzfeed/sso (https://github.com/buzzfeed/sso/tree/pr/63) to validate on our internal infrastructure so that we can get this merged! |
|
Good point, I’ll take care of it.
…On Fri, Sep 21, 2018 at 5:37 PM Shraya Ramani ***@***.***> wrote:
One more request - we should be able to also get rid of copying over the
static directory in the Dockerfile
<https://github.com/buzzfeed/sso/blob/6bc3c4473d78e94c00775f2297c3a540c7daf0d5/Dockerfile#L31>
when building the docker image.
Since we are still working on figuring out a good way to build and push
docker images for forked community contributions, I've pushed a copy of
your pr branch on buzzfeed/sso (https://github.com/buzzfeed/sso/tree/pr/63)
to validate on our internal infrastructure so that we can get this merged!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAG8hAICjhvhsYNMoYNCL_sgAgL8y7Cks5udYZhgaJpZM4WxFDW>
.
|
sporkmonger
force-pushed
the
static-assets
branch
2 times, most recently
from
139c3a6 to
9055aca
Compare
|
Thanks for making those changes @sporkmonger, this looks good to me, can you please squash the commits and I'll approve and merge! |
* Uses https://github.com/rakyll/statik to embed files * Minor changes to build, now uses Go 1.10 * Dockerfile no longer copies static files
sporkmonger
force-pushed
the
static-assets
branch
from
f61f24c to
a5a8639
Compare
|
All squashed! |
2 participants
Problem
Fixes #7, simplifies deployment.
Solution
Bake static assets into a
.gofile that functions as a file server.Notes
Opted to use https://github.com/rakyll/statik over https://github.com/jteeuwen/go-bindata since it's actively maintained.