Make BWAPI integrable into other projects#786
Merged
heinermann merged 4 commits intobwapi:developfrom Apr 19, 2018
N00byEdge:develop
Merged
Make BWAPI integrable into other projects#786heinermann merged 4 commits intobwapi:developfrom N00byEdge:develop
heinermann merged 4 commits intobwapi:developfrom
N00byEdge:develop
Conversation
Member
Author
|
Oh yeah, if it wasn't clear, the problem before was that BWAPI was trying to copy a lot of files around. Maybe this even should be removed from all the projects and be made into its own project, to not bloat as much. |
|
✅ Build bwapi 4.2.0.97-qmhycvem completed (commit 6aa4cec99f by @N00byEdge) |
Member
|
Sure I guess. This will all change in the bwapi5 branch when I finish that. |
Member
Author
|
Awesome, I'm fine with this being a temporary solution as long as there is something that can be used like this for BWAPI 5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should let people integrate BWAPI builds into their own. This can for example be used for having BWAPI projects available in unit/integration tests for bots or BWAPI dependent libraries as a submodule.
Example: https://ci.appveyor.com/project/N00byEdge/bwem-community/build/1.0.17-master/job/5ymygb5t199tjva6
I also had to patch SVNRevGen so that it generated
svnrev.hin the correct BWAPI directory, and not relative to the solution (since BWAPI isn't the active solution). It will now generate relative to the project itself.