nullptr initialisation of FormatArg pointers, runtime debug mode checks#43
Merged
c42f merged 2 commits intoc42f:masterfrom Oct 4, 2017
Merged
Conversation
Owner
|
Thanks, looks fine to me. |
krlmlr
reviewed
Oct 4, 2017
| const FormatList& list); | ||
|
|
||
| private: | ||
| FormatList(); |
Owner
There was a problem hiding this comment.
Good question actually. @nigels-com why did you add this?
Contributor
Author
There was a problem hiding this comment.
A FormatList default constructor looks like another place that ought to be doing initialisation.
Owner
There was a problem hiding this comment.
The default constructor is deleted because a nontrivial constructor was declared, so this should be unncessary. I'll remove it.
Contributor
Author
There was a problem hiding this comment.
Better to be explicit, IMHO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for Issue #42
Initialise FormatArg pointers in default constructor, runtime assertions.