Regression & unittest fixes#129
Merged
ATenderholt merged 15 commits intocclib:masterfrom Sep 15, 2014
Merged
Conversation
Member
Author
|
Since not merged yet, I will also add some unittest fixes... |
…beta orbitals (closes cclib#130)
Member
Author
|
I also put the fix for #130 here. |
…cs (regression Gaussian03/ortho_prod_freq.log)
src/cclib/parser/gamessparser.py
Outdated
Contributor
There was a problem hiding this comment.
Want to fix the typo in your comment? I assume not should be now...
Member
Author
|
Fixed the typo. Having the regression covered is good enough (well, it is for me :D). |
Member
Author
|
Basically, I wanted to get rid of all errors... and now I changed the config for Travis so that it will also fail on errors in the regression tests. Eventually, perhaps we want to fail Travis also for failures in the suite, but perhaps when we get those in order will be the right moment. |
ATenderholt
added a commit
that referenced
this pull request
Sep 15, 2014
Regression & unittest fixes
langner
pushed a commit
to langner/cclib
that referenced
this pull request
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #116 (regression Gaussian09/BH3_fragment_guess.pop_minimal.log).
I initially wanted also to fix regression Gaussian03/ortho_prod_freq.log but that requires a bit more investigation. That's an ONIOM job, and we need to figure out how to handle those for v1.3 reasonably (currently they break the parse), until we consider parsing fragments (I suppose this qualifies as a specific case).