You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
git config [--global] blame.ignoreRevsFile .git-blame-ignore-revs
# Mark any lines that have had a commit skipped using --ignore-rev with a `?`
git config --global blame.markIgnoredLines true# Mark any lines that were added in a skipped commit and can not be attributed with a `*`
git config --global blame.markUnblamableLines true
where I think the isort directives show as * because they are only from an ignored commit. The same appears for lines with isolated parens that were not previously on their own lines (see qchemparser.py and grep for 2023-12).
A slightly more confusing case is adfparser.py, but the lines from that date are all whitespace and correspond to the CRLF -> LF commit, and those changes seem to constitute a complete change rather than reuse whatever empty line was there before. But, they're not code lines.
@shivupa and @amandadumi , can one of you look at the git blame output of your favorite file after doing at least git config blame.ignoreRevsFile .git-blame-ignore-revs and see if it makes sense to you?
I think this looks good and seems to have worked. In a quick/narrow check, the nwchem parser went from seeing your name on every line of the git blame to only on what looks like newly added lines, which seems correct to me.
A slightly more confusing case is adfparser.py, but the lines from that date are all whitespace and correspond to the CRLF -> LF commit, and those changes seem to constitute a complete change rather than reuse whatever empty line was there before. But, they're not code lines.
I think as long as the code lines are mostly git blame-able we are in business.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1122
I did everything as outlined in https://www.michaelheap.com/git-ignore-rev/, though one may not want to set a global file:
And here are some examples of the output:
where I think the isort directives show as
*because they are only from an ignored commit. The same appears for lines with isolated parens that were not previously on their own lines (seeqchemparser.pyand grep for2023-12).A slightly more confusing case is
adfparser.py, but the lines from that date are all whitespace and correspond to the CRLF -> LF commit, and those changes seem to constitute a complete change rather than reuse whatever empty line was there before. But, they're not code lines.