Skip to content

Migrate to pyproject.toml for package installation#1311

Merged
berquist merged 4 commits intocclib:masterfrom
berquist:1180-pyproject-toml
Dec 19, 2023
Merged

Migrate to pyproject.toml for package installation#1311
berquist merged 4 commits intocclib:masterfrom
berquist:1180-pyproject-toml

Conversation

@berquist
Copy link
Member

@berquist berquist commented Dec 4, 2023

Closes #1180
Closes #833

It's now possible to do `python -m pip install '.[all]', but I wonder if that should include dev dependencies or just user "extras". I don't know what's usually done. @schneiderfelipe thoughts?

@berquist berquist added this to the v1.8.1 milestone Dec 4, 2023
@berquist
Copy link
Member Author

berquist commented Dec 4, 2023

Blocked on #1312

@schneiderfelipe
Copy link
Contributor

Closes #1180 Closes #833

It's now possible to do `python -m pip install '.[all]', but I wonder if that should include dev dependencies or just user "extras". I don't know what's usually done. @schneiderfelipe thoughts?

I wouldn't include dev deps in all, but I couldn't find a consensus (see here and here for instance).

@berquist berquist force-pushed the 1180-pyproject-toml branch from fa12fd2 to 6909520 Compare December 4, 2023 20:15
@berquist berquist merged commit a609197 into cclib:master Dec 19, 2023
@berquist berquist deleted the 1180-pyproject-toml branch December 19, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from setup.py to pyproject.toml Use extras_requires in setup.py for soft dependencies

2 participants