Standardize MissingAttributeError in top-level namespace#1747
Closed
Dxboy266 wants to merge 1 commit intocclib:masterfrom
Closed
Standardize MissingAttributeError in top-level namespace#1747Dxboy266 wants to merge 1 commit intocclib:masterfrom
Dxboy266 wants to merge 1 commit intocclib:masterfrom
Conversation
- Add MissingAttributeError to cclib/__init__.py - Remove duplicate definitions from: - cclib/io/filewriter.py - cclib/bridge/cclib2pyquante.py - cclib/bridge/cclib2pyscf.py - cclib/method/calculationmethod.py - Update test imports to use top-level import Closes cclib#1746
Member
|
While we develop a policy on AI-based contributions (#1749), I'm closing this as it is not in the intent of "good first issues" for them to be solved entirely by AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1746
Summary
MissingAttributeErrortocclib/__init__.pyas the single canonical definitioncclib/io/filewriter.pycclib/bridge/cclib2pyquante.pycclib/bridge/cclib2pyscf.pycclib/method/calculationmethod.pyChanges
10 files changed, 14 insertions(+), 13 deletions(-)
This is a simple refactoring that consolidates the
MissingAttributeErrorexception class into a single location for consistency and easier maintenance.