Conversation
If _POSIX_ is set, mingw will no longer prefix *some* function names with an underscore, which is expected by libfmt. Rather than handling them case by case, we'll just avoid the POSIX macros. Signed-off-by: Lucian Petrut <[email protected]>
|
The Travis CI failure is due to the Android NDK Gradle build failing. This failure is due to a build config step that is missing the version parameter in the The changes requested in this PR work in my test environment. |
|
@petrutlucian94 sorry, Lucian! i just noticed your PR. could you upstream this change to https://github.com/fmtlib/fmt ? |
Right away. |
|
@tchaikov it merged upstream: fmtlib#1696. Should I cherry-pick this commit or pull the entire master branch to |
|
@petrutlucian94 i pushed ceph-pacific to ceph/fmt already. and created ceph/ceph#35259 to pick up your change. |
|
That's great, thanks! I guess I can close this PR then. |
3 participants
If POSIX is set, mingw will no longer prefix some function names
with an underscore, which is expected by libfmt. Rather than handling
them case by case, we'll just avoid the POSIX macros.
Signed-off-by: Lucian Petrut [email protected]