allow LDAP mapping values to be lowercased#348
Merged
techknowlogick merged 1 commit intocesanta:mainfrom Sep 28, 2022
Merged
Conversation
Add the ability to lowercase values when creating label mappings from
LDAP attributes. In the example the groups that the user is a member of
could be mixed case which would make an ACL like:
match: { account: "/.+/", name: "${labels:groups}/*" }
Not possible. But with this change and the example applied it would be
possible.
techknowlogick
approved these changes
Sep 21, 2022
Collaborator
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Thanks so much for this contribution!
Contributor
Author
|
What next steps do I need to do to get this merged and released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to lowercase values when creating label mappings from LDAP attributes. In the example the groups that the user is a member of could be mixed case which would make an ACL like:
match: { account: "/.+/", name: "${labels:groups}/*" }
Not possible. But with this change and the example applied it would be possible.