Add option to adjust bcrypt hashing cost#375
Merged
techknowlogick merged 1 commit intocesanta:mainfrom Jan 2, 2024
Merged
Conversation
techknowlogick
approved these changes
Dec 24, 2023
Collaborator
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Thanks for this PR! Could you resolve conflicts :)
The defualt cost of 10 can be very prohibitive when the server is hit with more than ~10 simultaneous requests and only one CPU is available
andsens
force-pushed
the
ft-bcrypt-cost
branch
from
2386d50 to
6f7d27c
Compare
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default bcrypt hashing cost can be quite problematic when serving many requests at once. Depending on token expiration times and other security considerations, lowering the cost can be a valid fix. This PR adds the
token_hash_costto all TokenDB configs (redis, GCS, LevelDB). Note that the level db config was a simple string previously, I had to change it to a struct with{path: string, token_hash_cost: int}.Note that this PR is built on top of #374.