fix: PR metadata temp file missing .json extension#2846
Merged
migmartri merged 6 commits intochainloop-dev:mainfrom Mar 14, 2026
Merged
fix: PR metadata temp file missing .json extension#2846migmartri merged 6 commits intochainloop-dev:mainfrom
migmartri merged 6 commits intochainloop-dev:mainfrom
Conversation
Add wildcard to os.CreateTemp pattern so the random suffix is inserted before the extension instead of appended after it. Closes chainloop-dev#2845 Signed-off-by: Miguel Martinez Trivino <[email protected]>
matiasinsaurralde
approved these changes
Mar 14, 2026
jiparis
approved these changes
Mar 14, 2026
Signed-off-by: Miguel Martinez Trivino <[email protected]> # Conflicts: # pkg/attestation/crafter/crafter.go
Move the temp file JSON extension test to collector_prmetadata_test.go using table-driven tests, matching the new collector-based pattern. Add development guidelines for table-driven tests, TDD, and issue repo. Signed-off-by: Miguel Martinez Trivino <[email protected]>
![cubic-dev-ai[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/attestation/crafter/collector_prmetadata_test.go">
<violation number="1" location="pkg/attestation/crafter/collector_prmetadata_test.go:58">
P2: This test doesn't exercise the PR metadata collector; it only verifies a hand-written `os.CreateTemp` call, so it won't catch regressions in the actual implementation.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Extract a single helper that creates the temp file and returns the material name and file path, replacing inline formatting. Signed-off-by: Miguel Martinez Trivino <[email protected]>
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/attestation/crafter/collector_prmetadata.go">
<violation number="1" location="pkg/attestation/crafter/collector_prmetadata.go:96">
P2: Clean up the temp file on write failure; this refactor now leaks PR metadata files on the error path.</violation>
<violation number="2" location="pkg/attestation/crafter/collector_prmetadata.go:97">
P2: Check `Close()` for errors before returning the temp file path; otherwise delayed write failures are silently accepted.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Miguel Martinez Trivino <[email protected]>
Signed-off-by: Miguel Martinez Trivino <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.CreateTemppattern for PR/MR metadata files so the random suffix is placed before.jsoninstead of after it (e.g.pr-metadata-123<rand>.jsoninstead ofpr-metadata-123.json<rand>).jsonextensionCloses #2845