Skip to content

Improve build failure markdown comments#172

Merged
OpsBotPrime merged 5 commits intomasterfrom
improve-markdown-comments
Aug 23, 2022
Merged

Improve build failure markdown comments#172
OpsBotPrime merged 5 commits intomasterfrom
improve-markdown-comments

Conversation

@rudymatela
Copy link

@rudymatela rudymatela commented Aug 23, 2022 •
edited
Loading

Closes: #151
Closes: #168

Before

The build failed ❌
If this is the result of a flaky test, close and reopen the PR, then tag me again.
Otherwise, push a new commit and tag me again.

After

The build failed ❌

If this is the result of a flaky test, close and reopen the PR, then tag me again. Otherwise, push a new commit and tag me again.

Before

Speculative build failed. I will automatically retry after getting the results of #172.

After

Speculative build failed ❌. I will automatically retry after getting the results of #172.

Final result

1-white

2-white

1-black

2-black

@rudymatela rudymatela self-assigned this Aug 23, 2022
@rudymatela rudymatela added the enhancement New feature or request label Aug 23, 2022
@rudymatela
add markdown link for speculative failures
8ec6226 
... and simplify the whole handling of markdown failure links
@rudymatela
Fit some lines into 100 characters.
e90bcc9
@rudymatela
Copy link
Author

rudymatela commented Aug 23, 2022

@alex-mckenna Thanks for the review.

@OpsBotPrime merge

@OpsBotPrime
Copy link

OpsBotPrime commented Aug 23, 2022

Pull request approved for merge by @rudymatela, rebasing now.

@OpsBotPrime
Merge #172: Improve build failure markdown comments
9003116 
Approved-by: rudymatela
Auto-deploy: false
@OpsBotPrime
Copy link

OpsBotPrime commented Aug 23, 2022

Rebased as 9003116, waiting for CI …

@OpsBotPrime
Copy link

OpsBotPrime commented Aug 23, 2022

CI job started.

@OpsBotPrime OpsBotPrime merged commit 9003116 into master Aug 23, 2022
@OpsBotPrime OpsBotPrime deleted the improve-markdown-comments branch August 23, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alex-mckenna alex-mckenna alex-mckenna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rudymatela rudymatela

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add markdown link to speculative build failure comments Comment about build failures with a markdown link

3 participants

@rudymatela @OpsBotPrime @alex-mckenna