Skip to content

Update Go version requirement to 1.26+#12864

Merged
BagToad merged 1 commit intotrunkfrom
kw/update-build-from-source-to-go-1.26
Mar 7, 2026
Merged

Update Go version requirement to 1.26+#12864
BagToad merged 1 commit intotrunkfrom
kw/update-build-from-source-to-go-1.26

Conversation

@BagToad
Copy link
Member

@BagToad BagToad commented Mar 7, 2026

Small follow-up to #12860

Copilot AI review requested due to automatic review settings March 7, 2026 17:00
@BagToad BagToad requested a review from a team as a code owner March 7, 2026 17:00
@BagToad BagToad requested a review from babakks March 7, 2026 17:00
Copilot AI reviewed Mar 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documented Go toolchain requirement for building gh from source to align with the recent Go 1.26.x bump.

Changes:

  • Update source installation documentation to require Go 1.26+.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

babakks
babakks approved these changes Mar 7, 2026
View reviewed changes
Copy link
Member

@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also see if go1.26 image is available for our devcontainer.

@babakks
Copy link
Member

babakks commented Mar 7, 2026 •
edited
Loading

Also, we should upgrade Golangci-lint to v2.10.1 (since that's built with go1.26).

@BagToad
Copy link
Member Author

BagToad commented Mar 7, 2026

Also, we should upgrade Golangci-lint to v2.10.1 (since that's built with go1.26).

Already did that in #12860 :)

@BagToad BagToad force-pushed the kw/update-build-from-source-to-go-1.26 branch from 1b645dd to 7fa453e Compare March 7, 2026 17:11
@BagToad
Copy link
Member Author

BagToad commented Mar 7, 2026

@babakks doesn't seem like 1.26 devcontainer is out yet.

@BagToad BagToad merged commit 3d86738 into trunk Mar 7, 2026
9 checks passed
@BagToad BagToad deleted the kw/update-build-from-source-to-go-1.26 branch March 7, 2026 17:37
@babakks
Copy link
Member

babakks commented Mar 8, 2026

@babakks doesn't seem like 1.26 devcontainer is out yet.

Thanks for checking. Seems like they have the dev-1.26 tag, but not the stable 1.26. I just commented on an issue in their repo, devcontainers/images#1792 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@babakks babakks babakks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BagToad @babakks