Support authorization url#228
Merged
qiwzhang merged 4 commits intocloudendpoints:masterfrom Aug 1, 2017
qiwzhang:authorization_url
Merged
Support authorization url#228qiwzhang merged 4 commits intocloudendpoints:masterfrom qiwzhang:authorization_url
qiwzhang merged 4 commits intocloudendpoints:masterfrom
qiwzhang:authorization_url
Conversation
Contributor
Any documentation describing this behavior? I couldn't find this in OpenAPI spec. |
Contributor
Author
|
Flex team requires us to behave such way to support their Auth. |
Contributor
|
From: OpenAPI spec and OpenID Connect spec I feel the redirection should also include more request parameters extract from JWT, no? The code itself LGTM. |
mangchiandjjoe
approved these changes
Aug 1, 2017
Contributor
|
Just ran into this "feature" which really sounds like a bug to me. Why should presence of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If authentication fail with invalid token or expired token, and if authorization url is set, response with 302 with that url.