Zero copy stream implement skip and count#796
Zero copy stream implement skip and count#796bnordli wants to merge 2 commits intocloudendpoints:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Test failure is due to code format Files not formatted: src/grpc/zero_copy_stream_test.cc whch is enforced by this script |
|
@bnordli if you don't mind, I can take over your change, and use a separate to submit it. |
|
That's fine with me, @qiwzhang, and probably much quicker too! Thanks :) (I didn't have a build environment and just tried to follow the general formatting.) We requested a CLA for my company today, but it seems like I committed with my personal email. Hopefully everything should be alright using [email protected]. |
|
No, the commit has the correct email. Let's check if my boss signed the CLA. @googlebot I signed it! |
Fixes #795.
(Pair programming with @oyvindwe. He has the build environment, so he will verify compilation and tests later.)