Add appengine's nginx latency status module.#810
Add appengine's nginx latency status module.#810qiwzhang merged 9 commits intocloudendpoints:masterfrom
Conversation
|
/ok-to-test |
|
bazel build failed with following error: ERROR: /home/jenkins/.cache/bazel/_bazel_root/752dabe8e6eb24287f1fbb3854c08f93/external/appengine_nginx/third_party/nginx_latency_status_module/src/BUILD:49:1: C++ compilation of rule '@appengine_nginx//third_party/nginx_latency_status_module/src:ngx_latency_status_lib' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -MD -MF ... (remaining 128 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox |
|
Let me know once the change is ready for test. I need to manually trigger a presubmit test. |
|
Build failed with error ERROR: /home/jenkins/.cache/bazel/_bazel_root/752dabe8e6eb24287f1fbb3854c08f93/external/appengine_nginx/third_party/nginx_latency_status_module/src/BUILD:30:1: C++ compilation of rule '@appengine_nginx//third_party/nginx_latency_status_module/src:ngx_latency_status_module' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -MD -MF ... (remaining 129 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox |
|
@imccarten1 you may have to setup ESP build environment to pass local build first. You could not rely on CI/CT to test your local build. |
Also improves the formatting of appengine's latency status modules's output json.
Note that this involves adding a gitmodule.
.gitmodules
Outdated
| path = third_party/nginx-tests | ||
| url = https://nginx.googlesource.com/nginx-tests | ||
| ignore = untracked | ||
| [submodule "third_party/appengine-nginx-tests"] |
There was a problem hiding this comment.
Please don't use git submodule. We already include this in WORKSPACE dependency.
| @@ -0,0 +1,189 @@ | |||
| #!/usr/bin/perl | |||
There was a problem hiding this comment.
could you
- create a sub-folder "nginx_latency_status_module" for this file
- add a README.md in that folder to describe the original source of the "t" file
- use a separate BUILD file for this t test. not to mixed with ngix-tests
2 participants
Note that this is dependent on pull request GoogleCloudPlatform/appengine-sidecars-docker#153 for the appengine sidecars repository being completed.