nginx: do not error out on warning#305
nginx: do not error out on warning#305jhellan wants to merge 1 commit intocloudfoundry-attic:masterfrom jhellan:no_werror
Conversation
|
Hey jhellan! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: http://www.pivotaltracker.com/story/show/66404336 |
|
I think that this issue has been resolved by updating nginx to 1.4.5 |
|
yudai is right. We're now running unpatched cf v160 on a precise stemcell. |
6 participants
This pull request disables "-Werror" when building nginx. Our custom CPI needs Precise, so that's what our Bosh stemcells use. On Precise, the compiler warns about two unused variables, and "-Werror" makes the build error out.
Up to cf 155, we haven't been building nginx at all, and been setting the ccng.use_nginx flag to false. When that flag disappeared with 3343556, we disabled "-Werror" instead. This shouldn't hurt when building on Lucid, so we're hoping you will approve this pull request.
Jon Kåre Hellan, UNINETT AS, Trondheim, Norway