Fix Missing GUID in CloudController Application Type ( V8)#3552
Merged
gururajsh merged 2 commits intocloudfoundry:v8from Jul 21, 2025
Merged
Fix Missing GUID in CloudController Application Type ( V8)#3552gururajsh merged 2 commits intocloudfoundry:v8from
gururajsh merged 2 commits intocloudfoundry:v8from
Conversation
Signed-off-by: Dilip Tadepalli <[email protected]>
|
/easycla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR ensures that the Application struct in resources/application.go correctly unmarshals the guid field from the Cloud Controller response JSON. Previously, although the GUID field was defined in the struct, it was not being populated in the UnmarshalJSON method.This caused the Application.GUID field to remain empty during deserialization, potentially impacting downstream logic that relies on application GUIDs for identification or operations.
The fix adds a.GUID = ccApp.GUID in the custom UnmarshalJSON method to correctly populate the GUID.
Why Is This PR Valuable?
Applicable Issues
No linked GitHub issue yet.
How Urgent Is The Change?
Moderately urgent – this fix is important for correct behaviour, especially in automated or programmatic usage of the CF CLI. While not breaking existing commands, it silently fails to expose critical application metadata. One of my test case is failing as I leverage app GUID.
Other Relevant Parties