Conversation
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
dosubot
bot
added
size:M
Member
Author
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22232434210 |
mnencia
force-pushed
the
dev/10034
branch
2 times, most recently
from
d4c534d to
538d89c
Compare
dosubot
bot
added
size:L
Remove the pod existence check from the executor, as fencing operates on a Cluster-level annotation and should not depend on pod existence. Move instance validation to the kubectl plugin fencingOn command instead. Closes #10034 Signed-off-by: Marco Nenciarini <[email protected]>
Add tests for fencingOn and fencingOff functions covering known/unknown instance validation, wildcard fencing, and the edge case where an instance is no longer in InstanceNames but still fenced. Signed-off-by: Armando Ruocco <[email protected]>
jbattiato
approved these changes
Feb 27, 2026
armru
approved these changes
Feb 27, 2026
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…#10035) Remove the pod existence check from the executor, as fencing operates on a Cluster-level annotation and should not depend on pod existence. Move instance validation to the kubectl plugin fencingOn command instead. Closes #10034 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 3d6e698)
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…#10035) Remove the pod existence check from the executor, as fencing operates on a Cluster-level annotation and should not depend on pod existence. Move instance validation to the kubectl plugin fencingOn command instead. Closes #10034 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 3d6e698)
cnpg-bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…#10035) Remove the pod existence check from the executor, as fencing operates on a Cluster-level annotation and should not depend on pod existence. Move instance validation to the kubectl plugin fencingOn command instead. Closes #10034 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 3d6e698)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the pod existence check from the executor, as fencing operates on a Cluster-level annotation and should not depend on pod existence. Move instance validation to the kubectl plugin fencingOn command instead.
Closes #10034