Conversation
dosubot
bot
added
the
size:M
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22767021629 |
jbattiato
force-pushed
the
dev/10132
branch
4 times, most recently
from
ff56810 to
48489e8
Compare
dosubot
bot
added
size:L
jbattiato
force-pushed
the
dev/10132
branch
2 times, most recently
from
3304103 to
1b8a249
Compare
jbattiato
approved these changes
Mar 10, 2026
…tegy Previously, the service reconciler only detected changes in selectors, labels, and annotations. Changes to other spec fields like loadBalancerSourceRanges were silently ignored when using the patch update strategy, requiring users to switch to the replace strategy (which causes downtime) to apply spec changes. Now the reconciler compares the full service spec while preserving Kubernetes-managed fields (ClusterIP, ClusterIPs, IPFamilies, IPFamilyPolicy, InternalTrafficPolicy, SessionAffinity, ExternalTrafficPolicy, HealthCheckNodePort, NodePort, Protocol, TargetPort) via a reusable PreserveKubernetesDefaults function in pkg/servicespec. Closes #10132 Signed-off-by: Armando Ruocco <[email protected]>
…tion The Pooler service reconciler was overwriting the entire ServiceSpec from the expected service without preserving Kubernetes-managed fields (ClusterIP, SessionAffinity, IPFamilies, etc.), causing unnecessary API updates on every reconciliation loop. Use servicespec.PreserveKubernetesDefaults to copy Kubernetes-assigned and Kubernetes-defaulted fields from the living service before comparing specs. Signed-off-by: Armando Ruocco <[email protected]>
Kubernetes defaults AllocateLoadBalancerNodePorts to true for LoadBalancer services. Without preserving this field, every reconciliation loop would trigger an unnecessary update for LoadBalancer services. Signed-off-by: Armando Ruocco <[email protected]>
leonardoce
approved these changes
Mar 12, 2026
dosubot
bot
added
size:XL
mnencia
approved these changes
Mar 12, 2026
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/23011368014 |
Signed-off-by: Marco Nenciarini <[email protected]>
Member
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…tegy (#10190) Previously, the cluster and pooler service reconcilers only detected changes in selectors, labels, and annotations. Changes to other spec fields like loadBalancerSourceRanges were silently ignored when using the patch update strategy, requiring users to switch to the replace strategy (which causes downtime) to apply spec changes. Now the reconcilers compare the full service spec while preserving Kubernetes-managed and defaulted fields like ClusterIP, NodePort, and traffic policies. Closes #10132 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit c16f748)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…tegy (#10190) Previously, the cluster and pooler service reconcilers only detected changes in selectors, labels, and annotations. Changes to other spec fields like loadBalancerSourceRanges were silently ignored when using the patch update strategy, requiring users to switch to the replace strategy (which causes downtime) to apply spec changes. Now the reconcilers compare the full service spec while preserving Kubernetes-managed and defaulted fields like ClusterIP, NodePort, and traffic policies. Closes #10132 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit c16f748)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…tegy (#10190) Previously, the cluster and pooler service reconcilers only detected changes in selectors, labels, and annotations. Changes to other spec fields like loadBalancerSourceRanges were silently ignored when using the patch update strategy, requiring users to switch to the replace strategy (which causes downtime) to apply spec changes. Now the reconcilers compare the full service spec while preserving Kubernetes-managed and defaulted fields like ClusterIP, NodePort, and traffic policies. Closes #10132 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Marco Nenciarini <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> (cherry picked from commit c16f748)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the cluster and pooler service reconcilers only detected changes in selectors, labels, and annotations. Changes to other spec fields like loadBalancerSourceRanges were silently ignored when using the patch update strategy, requiring users to switch to the replace strategy (which causes downtime) to apply spec changes.
Now the reconcilers compare the full service spec while preserving Kubernetes-managed and defaulted fields like ClusterIP, NodePort, and traffic policies.
Closes #10132