fix(recovery): fix external cluster validation#10268
Merged
leonardoce merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
armru
changed the title
armru
changed the title
armru
approved these changes
Mar 10, 2026
Contributor
|
/test |
Contributor
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22905182061 |
Add missing check for `ConnectionParameters` in `validateBootstrapRecoverySource` and update the error message to include all valid configuration types. Closes #10260 Signed-off-by: Gabriele Bartolini <[email protected]>
Also removed the sourceName check given that it was already done Signed-off-by: Armando Ruocco <[email protected]>
Contributor
|
/ok-to-merge failures are not related |
leonardoce
approved these changes
Mar 10, 2026
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Add missing check for `ConnectionParameters` in `validateBootstrapRecoverySource` and update the error message to include all valid configuration types. Closes #10260 Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 6ee3d66)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Add missing check for `ConnectionParameters` in `validateBootstrapRecoverySource` and update the error message to include all valid configuration types. Closes #10260 Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 6ee3d66)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Add missing check for `ConnectionParameters` in `validateBootstrapRecoverySource` and update the error message to include all valid configuration types. Closes #10260 Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 6ee3d66)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing check for
ConnectionParametersinvalidateBootstrapRecoverySourceand update the error message to include all valid configuration types.Closes #10260