Skip to content

fix(plugin): do not append pgData if walName already contains it#6964

Merged
mnencia merged 1 commit intomainfrom
dev/wal-fix
Feb 25, 2025
Merged

fix(plugin): do not append pgData if walName already contains it#6964
mnencia merged 1 commit intomainfrom
dev/wal-fix

Conversation

@armru
Copy link
Member

@armru armru commented Feb 25, 2025 •
edited by leonardoce
Loading

This patch prevents the plugin executor to append $PGDATA/pg_wal two times
when the archiving of a WAL file is requested.

This was happening when archiving the ready WALs in a former primary.

Fixes: #6965
Fixes: cloudnative-pg/plugin-barman-cloud#164

@armru armru requested a review from a team as a code owner February 25, 2025 09:24
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.24 release-1.25 labels Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru armru added no-issue and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.24 release-1.25 labels Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@leonardoce leonardoce self-assigned this Feb 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@leonardoce
Copy link
Contributor

leonardoce commented Feb 25, 2025

This is just a quick fix with the intent of avoiding any side effects.
A more proper refactor will address the underlying issue and ensure that plugins will be called in the same way as PostgreSQL calls archive_command.

@leonardoce
Copy link
Contributor

leonardoce commented Feb 25, 2025

E2e: https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/13518560107

@leonardoce
Copy link
Contributor

leonardoce commented Feb 25, 2025

The E2e test run failed because of #6932
I'm starting it again.

https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/13523799301

@mnencia
Copy link
Member

mnencia commented Feb 25, 2025

/ok-to-merge E2E green on EDB fork

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Feb 25, 2025
@mnencia mnencia merged commit 918f9b0 into main Feb 25, 2025
25 checks passed
@mnencia mnencia deleted the dev/wal-fix branch February 25, 2025 17:37
@ardentperf ardentperf mentioned this pull request Sep 8, 2025
Merged
@Endevir Endevir mentioned this pull request Nov 6, 2025
Closed
Endevir pushed a commit to Endevir/cloudnative-pg that referenced this pull request Nov 6, 2025
@armru @Endevir
fix(plugin): do not append pgData if walName already contains it (clo…
b40c989 
…udnative-pg#6964)

This patch prevents the plugin executor from appending `$PGDATA/pg_wal` two
times when the archiving of a WAL file is requested.

This was happening when archiving the ready WALs in a former primary.

Fixes: cloudnative-pg#6965
Fixes: cloudnative-pg/plugin-barman-cloud#164

Signed-off-by: Armando Ruocco <[email protected]>
@Endevir Endevir mentioned this pull request Nov 6, 2025
Merged
@leonardoce leonardoce mentioned this pull request Nov 12, 2025
Closed
4 tasks
leonardoce pushed a commit that referenced this pull request Nov 12, 2025
@Endevir @armru
fix(plugin): fix duplicating pgData on walrestore (#9093)
70d884f 
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
cnpg-bot pushed a commit that referenced this pull request Nov 12, 2025
@Endevir @armru
fix(plugin): fix duplicating pgData on walrestore (#9093)
1b4be0b 
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
(cherry picked from commit 70d884f)
cnpg-bot pushed a commit that referenced this pull request Nov 12, 2025
@Endevir @armru
fix(plugin): fix duplicating pgData on walrestore (#9093)
be002e7 
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
(cherry picked from commit 70d884f)
leonardoce pushed a commit that referenced this pull request Nov 12, 2025
@Endevir @armru @leonardoce
fix(plugin): fix duplicating pgData on walrestore (#9093)
443e9b8 
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
(cherry picked from commit 70d884f)
mnencia pushed a commit that referenced this pull request Jan 20, 2026
@Endevir @armru @mnencia
fix(plugin): fix duplicating pgData on walrestore (#9093)
787489d 
This commit fixes incorrect walrestore path passed to plugins if
destination path is already absolute.

See #6964
Closes #9067

Signed-off-by: Ivan Arkhipov <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
(cherry picked from commit 70d884f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnencia mnencia mnencia approved these changes

@leonardoce leonardoce leonardoce approved these changes

Assignees

@leonardoce leonardoce

Labels

ok to merge 👌 This PR can be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: WAL archiving on former primary is triggered with an absolute path [bug] WAL archiving not working on former primary

4 participants

@armru @leonardoce @mnencia @cnpg-bot