fix(publication): ensure PostgreSQL 13+ compatibility for multi-table publications#8888
Merged
gbartolini merged 3 commits intomainfrom Nov 1, 2025
Merged
fix(publication): ensure PostgreSQL 13+ compatibility for multi-table publications#8888gbartolini merged 3 commits intomainfrom
gbartolini merged 3 commits intomainfrom
Conversation
dosubot
bot
added
the
size:L
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18656354632 |
armru
force-pushed
the
dev/8588
branch
2 times, most recently
from
f63ada9 to
834348f
Compare
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18676589645 |
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18741963356 |
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18741991753 |
leonardoce
force-pushed
the
dev/8588
branch
2 times, most recently
from
42a8889 to
df6a91b
Compare
leonardoce
approved these changes
Oct 30, 2025
Contributor
|
/test |
Contributor
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18947070276 |
… publications Fix SQL generation for publications with multiple tables to support PostgreSQL 13+. The previous implementation generated SQL that only worked on PostgreSQL 15+: CREATE PUBLICATION "pub" FOR TABLE "t1", TABLE "t2" While this syntax is valid in PostgreSQL 15+, it fails in PostgreSQL 13+ with a syntax error. The fix now generates backward-compatible SQL: CREATE PUBLICATION "pub" FOR TABLE "t1", "t2" The implementation groups consecutive tables under a single TABLE keyword and properly handles mixed scenarios with TABLES IN SCHEMA, ensuring full compatibility across all supported PostgreSQL versions (13+). Fixes #8588 Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
gbartolini
approved these changes
Nov 1, 2025
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
…table publications (#8888) The previous implementation generated SQL valid only in PostgreSQL 15+, for example: CREATE PUBLICATION "pub" FOR TABLE "t1", TABLE "t2"; This syntax causes a syntax error in PostgreSQL 13 and 14. The fix updates the SQL generation to produce backward-compatible statements such as: CREATE PUBLICATION "pub" FOR TABLE "t1", "t2"; The new implementation groups consecutive tables under a single `TABLE` keyword and correctly handles mixed cases involving `TABLES IN SCHEMA`, ensuring full compatibility across all supported PostgreSQL versions (13+). Fixes #8588. Signed-off-by: Armando Ruocco [[email protected]](mailto:[email protected]) Signed-off-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) Co-authored-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) (cherry picked from commit 514a43d)
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
…table publications (#8888) The previous implementation generated SQL valid only in PostgreSQL 15+, for example: CREATE PUBLICATION "pub" FOR TABLE "t1", TABLE "t2"; This syntax causes a syntax error in PostgreSQL 13 and 14. The fix updates the SQL generation to produce backward-compatible statements such as: CREATE PUBLICATION "pub" FOR TABLE "t1", "t2"; The new implementation groups consecutive tables under a single `TABLE` keyword and correctly handles mixed cases involving `TABLES IN SCHEMA`, ensuring full compatibility across all supported PostgreSQL versions (13+). Fixes #8588. Signed-off-by: Armando Ruocco [[email protected]](mailto:[email protected]) Signed-off-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) Co-authored-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) (cherry picked from commit 514a43d)
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
…table publications (#8888) The previous implementation generated SQL valid only in PostgreSQL 15+, for example: CREATE PUBLICATION "pub" FOR TABLE "t1", TABLE "t2"; This syntax causes a syntax error in PostgreSQL 13 and 14. The fix updates the SQL generation to produce backward-compatible statements such as: CREATE PUBLICATION "pub" FOR TABLE "t1", "t2"; The new implementation groups consecutive tables under a single `TABLE` keyword and correctly handles mixed cases involving `TABLES IN SCHEMA`, ensuring full compatibility across all supported PostgreSQL versions (13+). Fixes #8588. Signed-off-by: Armando Ruocco [[email protected]](mailto:[email protected]) Signed-off-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) Co-authored-by: Gabriele Bartolini [[email protected]](mailto:[email protected]) (cherry picked from commit 514a43d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation generated SQL that only worked on PostgreSQL 15+:
CREATE PUBLICATION "pub" FOR TABLE "t1", TABLE "t2"
While this syntax is valid in PostgreSQL 15+, it fails in PostgreSQL 13+ with a syntax error. The fix now generates backward-compatible SQL:
CREATE PUBLICATION "pub" FOR TABLE "t1", "t2"
The implementation groups consecutive tables under a single TABLE keyword and properly handles mixed scenarios with TABLES IN SCHEMA, ensuring full compatibility across all supported PostgreSQL versions (13+).
Fixes #8588
Note for reviewers