Skip to content

feat(plugin): implement finalizer to cleanup plugins on service deletion#9560

Merged
leonardoce merged 1 commit intomainfrom
dev/cleanup-deleted-service
Mar 6, 2026
Merged

feat(plugin): implement finalizer to cleanup plugins on service deletion#9560
leonardoce merged 1 commit intomainfrom
dev/cleanup-deleted-service

Conversation

@armru
Copy link
Member

@armru armru commented Dec 23, 2025

Add finalizer handling to properly remove plugins from the pool when their associated service is deleted. This prevents orphaned plugins from remaining registered after their service has been removed from the cluster.

@armru armru requested a review from a team as a code owner December 23, 2025 15:33
@armru armru added the no-issue label Dec 23, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 23, 2025
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.27 release-1.28 labels Dec 23, 2025
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@dosubot dosubot bot added the bug 🐛 Something isn't working label Dec 23, 2025
@armru
Copy link
Member Author

armru commented Dec 23, 2025

/test

@github-actions
Copy link
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20464984462

@armru armru changed the title fix(plugin): implement finalizer to cleanup plugins on service deletion feat(plugin): implement finalizer to cleanup plugins on service deletion Dec 23, 2025
@armru armru added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.27 release-1.28 bug 🐛 Something isn't working labels Dec 23, 2025
@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Dec 23, 2025
@mnencia mnencia force-pushed the dev/cleanup-deleted-service branch 3 times, most recently from b5e23f6 to 02295ef Compare February 3, 2026 14:45
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2026
@mnencia mnencia force-pushed the dev/cleanup-deleted-service branch from 02295ef to 53d7ca4 Compare February 23, 2026 08:01
@leonardoce leonardoce force-pushed the dev/cleanup-deleted-service branch 2 times, most recently from 0fc186a to 8fb6842 Compare March 5, 2026 12:59
@leonardoce
Copy link
Contributor

/test

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/22719571968

@leonardoce leonardoce force-pushed the dev/cleanup-deleted-service branch from 8fb6842 to ea809c5 Compare March 5, 2026 16:05
Add finalizer handling to properly remove plugins from the pool when
their associated service is deleted. This prevents orphaned plugins
from remaining registered after their service has been removed from
the cluster.

Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
@leonardoce leonardoce force-pushed the dev/cleanup-deleted-service branch from ea809c5 to 0d654cd Compare March 6, 2026 07:50
@leonardoce leonardoce merged commit 65bf7fa into main Mar 6, 2026
33 checks passed
@leonardoce leonardoce deleted the dev/cleanup-deleted-service branch March 6, 2026 08:00
danishedb pushed a commit to danishedb/cloudnative-pg that referenced this pull request Mar 6, 2026
…ion (cloudnative-pg#9560)

Add finalizer handling to properly remove plugins from the pool when
their associated service is deleted. This prevents orphaned plugins from
remaining registered after their service has been removed from the
cluster.

Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport This PR must not be backported - it will be in the next minor release lgtm This PR has been approved by a maintainer no-issue ok to merge 👌 This PR can be merged size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants